Make set_span take mut self #78047
Merged
Make set_span take mut self #78047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
camelid
added
C-cleanup
jyn514
added
the
T-compiler
|
@bors delegate=bjorn3 |
|
✌️ @bjorn3 can now approve this pull request |
|
Makes sense @bors r+ |
|
📌 Commit 3d48448 has been approved by |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions, checks-azure |
26 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a mistake in #77614
It's not a huge deal, because backends can always implement this with interior mutability, but it's nice to avoid interior mutability when possible. For context, the
set_source_locationmethod, called alongsideset_span, also takes&mut self.r? @eddyb